From d270b4a4687eda6da6770510471f6787eb3109c0 Mon Sep 17 00:00:00 2001 From: Iskander Sharipov Date: Thu, 13 Sep 2018 21:16:50 +0300 Subject: [PATCH] simplify (*x).f to x.f where it does not change the semantics Found using https://go-critic.github.io/overview#underef-ref --- services/http/http.go | 2 +- services/sps/sps.go | 2 +- services/tcp/tcp.go | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/services/http/http.go b/services/http/http.go index 5685342..b079c29 100644 --- a/services/http/http.go +++ b/services/http/http.go @@ -172,7 +172,7 @@ func (s *HTTP) InitService() (err error) { s.InitLB() } if *s.cfg.DNSAddress != "" { - (*s).domainResolver = dnsx.NewDomainResolver(*s.cfg.DNSAddress, *s.cfg.DNSTTL, s.log) + s.domainResolver = dnsx.NewDomainResolver(*s.cfg.DNSAddress, *s.cfg.DNSTTL, s.log) } if *s.cfg.ParentType == "ssh" { err = s.ConnectSSH() diff --git a/services/sps/sps.go b/services/sps/sps.go index da1bad9..c2e45d4 100644 --- a/services/sps/sps.go +++ b/services/sps/sps.go @@ -145,7 +145,7 @@ func (s *SPS) CheckArgs() (err error) { func (s *SPS) InitService() (err error) { if *s.cfg.DNSAddress != "" { - (*s).domainResolver = dnsx.NewDomainResolver(*s.cfg.DNSAddress, *s.cfg.DNSTTL, s.log) + s.domainResolver = dnsx.NewDomainResolver(*s.cfg.DNSAddress, *s.cfg.DNSTTL, s.log) } if len(*s.cfg.Parent) > 0 { diff --git a/services/tcp/tcp.go b/services/tcp/tcp.go index 4f4c792..68b96ed 100644 --- a/services/tcp/tcp.go +++ b/services/tcp/tcp.go @@ -208,8 +208,8 @@ func (s *TCP) OutToUDP(inConn *net.Conn) (err error) { srcAddr := "" defer func() { if item != nil { - (*(*item).conn).Close() - (*item).udpConn.Close() + (*item.conn).Close() + item.udpConn.Close() s.udpConns.Remove(srcAddr) (*inConn).Close() } @@ -252,8 +252,8 @@ func (s *TCP) OutToUDP(inConn *net.Conn) (err error) { } else { item = v.(*UDPConnItem) } - (*item).touchtime = time.Now().Unix() - go (*item).udpConn.Write(body) + item.touchtime = time.Now().Unix() + go item.udpConn.Write(body) } } func (s *TCP) UDPRevecive(key string) {